Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the onboarding e2e test #21271

Closed
williamhbaker opened this issue Apr 21, 2021 · 1 comment · Fixed by #21272 or #21279
Closed

Update the onboarding e2e test #21271

williamhbaker opened this issue Apr 21, 2021 · 1 comment · Fixed by #21272 or #21279
Assignees
@williamhbaker
Labels
area/ui area/2.x OSS 2.0 related issues and PRs

Comments

@williamhbaker
Copy link
Contributor

The onboarding e2e test needs to be updated based on changes in the ui repo, see ui#1146. It should look for the splash page text of Welcome to InfluxDB now, instead of the more-specific Welcome to InfluxDB 2.0, since the same splash page text is used for both cloud and OSS.

Once we get ui#1007 implemented we will not have to keep the two tests suites in sync, but for now this will allow OSS to continue to use the latest UI and not have its CI tests fail.
@williamhbaker williamhbaker added area/ui area/2.x OSS 2.0 related issues and PRs labels Apr 21, 2021
@williamhbaker williamhbaker self-assigned this Apr 21, 2021
@williamhbaker williamhbaker mentioned this issue Apr 21, 2021
Merged
@williamhbaker
Copy link
Contributor Author

Re-opening this since there is actually an additional test that uses this exact same test to match that needs to be updated - also within the onboarding e2e test here.

@williamhbaker williamhbaker reopened this Apr 22, 2021
@williamhbaker williamhbaker mentioned this issue Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamhbaker williamhbaker

Labels
area/ui area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Milestone
No milestone
1 participant
@williamhbaker