Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table thresholds are not functional #15904

Closed
desa opened this issue Nov 14, 2019 · 6 comments · Fixed by #16172
Closed

Table thresholds are not functional #15904

desa opened this issue Nov 14, 2019 · 6 comments · Fixed by #16172

Comments

@desa
Copy link
Contributor

desa commented Nov 14, 2019

  1. Threshold colors are not applied to table

no-threshold-coloring

  1. Threshold settings do not persist

threshold-settings-dont-persist

@desa
Copy link
Contributor Author

desa commented Nov 14, 2019

cc @r1ckbrown

@desa
Copy link
Contributor Author

desa commented Nov 18, 2019

Link #15803

@asalem1 asalem1 self-assigned this Dec 6, 2019
@asalem1
Copy link
Contributor

asalem1 commented Dec 6, 2019

@desa should the threshold colors be set on the _value column text? Background? The entire row?

The data is persistent when hitting the enter key after creating a threshold, should the functionality be updated to persist under other conditions?

@sjwang90
Copy link

sjwang90 commented Dec 6, 2019

My suggestion would be the threshold colors on the entire row. If something is critical, I would want to follow the entire row to see what time/field info that critical point occurred. The user could toggle if they wanted the color on the background or text similar to the single stat.

@r1ckbrown
Copy link

This is how it's working in v1
image
image

@asalem1
Copy link
Contributor

asalem1 commented Dec 9, 2019

Screen Shot 2019-12-09 at 10 47 48

@r1ckbrown & @sjwang90 here's what I've got for it so far, should we go ahead and commit to this UI or refactor it so that the entire row is the same color?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants