Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cannot read properties of undefined (reading 'status') issue #298

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix Cannot read properties of undefined (reading 'status') issue #298

merged 1 commit into from
Aug 22, 2022

Conversation

treeduship
Copy link
Contributor

Resolves #295

@treeduship
Copy link
Contributor Author

treeduship commented Jul 28, 2022 •
edited
Loading

This does the same thing that's being done here:

apisauce/lib/apisauce.ts

Lines 256 to 257 in 582186f

const status = (response && response.status) || null
const problem = isError ? getProblemFromError(axiosResult) : getProblemFromStatus(status)

@treeduship treeduship changed the title Update apisauce.ts Fix Cannot read properties of undefined (reading 'status') issue Jul 28, 2022
@jamonholmgren jamonholmgren merged commit 278bfbc into infinitered:master Aug 22, 2022
@jamonholmgren
Copy link
Member

Thanks @treeduship! Really appreciate the PR.

infinitered-circleci pushed a commit that referenced this pull request Aug 22, 2022
@semantic-release-bot
chore(release): 2.1.6 [skip ci]
6634bf8 
## [2.1.6](v2.1.5...v2.1.6) (2022-08-22)

### Bug Fixes

* Fixes undefined status error -- fixes [#295](#295) ([#298](#298) by [@treeduship](https://github.com/treeduship)) ([278bfbc](278bfbc))
@infinitered-circleci
Copy link

🎉 This PR is included in version 2.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'status')
3 participants
@treeduship @jamonholmgren @infinitered-circleci