Removing Ramda (from prod build) and going from 19k to 6k #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dissoc, keys, forEach,
examples/github.js
Outdated
| R.concat('Calls remaining this hour: '), | ||
| console.log | ||
| ) | ||
| R.pipe(RS.dotPath('headers.x-ratelimit-remaining'), R.concat('Calls remaining this hour: '), console.log), |
There was a problem hiding this comment.
I know this is automatic reformatting, but the Elixirist in me thinks that each pipe on its own line looks better!
There was a problem hiding this comment.
I agree! I might force it to do things differently here.
There was a problem hiding this comment.
I actually want to de-ramdaify this file as well, as I think it does more harm than good here.
There was a problem hiding this comment.
Probably not worth forcing the formatting - I was just nitpicking about how sometimes the automated tooling goofs
infinitered-circleci
pushed a commit
that referenced
this pull request
Dec 17, 2021
## [2.1.4](v2.1.3...v2.1.4) (2021-12-17) ### Bug Fixes * **deps:** Removes ramda.js ([#281](#281) by [@jamonholmgren](https://github.com/jamonholmgren)) ([638df8b](638df8b))
|
🎉 This PR is included in version 2.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Ramda from our production build of apisauce. (It's still present in devDependencies because I didn't feel like untangling the tests.)
As you can see, the size win is significant -- 1k less for commonjs and 13k less for umd (not sure why umd has such a huge win, but i'll take it).
At some point it would be nice to remove Ramda from the tests too, but that's a chore.