Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sns default value #42

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

antongolub
Copy link
Contributor

@antongolub antongolub commented Jan 15, 2022

CC @1000ch

After v7.0.0 update, another image appeared with the same options.

antongolub-forks@90977fe brings cwebp-bin@6 which uses imagemin/cwebp-bin@7f49333 cwebp-1.2.1 which now uses sns=50 as default

So the docs should be updated.

@antongolub
Copy link
Contributor Author

antongolub commented Jan 16, 2022

or maybe it's better to restore the prev default?

if (options.sns) {
  args.push('-sns', options.sns);
}

args.push('-sns', options.sns !== undefined ?  options.sns : 80);

@1000ch 1000ch merged commit 9f29bdf into imagemin:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants