Skip to content

Consider adding golden tests #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n-bernat opened this issue Mar 29, 2025 · 1 comment
Open

Consider adding golden tests #1887

n-bernat opened this issue Mar 29, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@n-bernat
Copy link

When developing new features it's important to avoid regressions.

Since this package is very UI-specific, golden tests would be useful to ensure that nothing breaks.

While I'm working on rounded section radius for the pie chart, I've noticed some issues with my implementation, that would be easier to spot early on with golden tests that provide a reference image.

There is a package called alchemist that can help implement golden tests.

@imaNNeo
Copy link
Owner

imaNNeo commented May 3, 2025

Hi @n-bernat
Thanks for your great suggestion.
I remember we had some golden tests, but we decided to remove them (I don't remember the reason)
But I agree that they are super helpful here.

Do you have time to help us set it up?
You can start simple and add a simple test for a chart

@imaNNeo imaNNeo added the enhancement New feature or request label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants