Added Node.js workflow. #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took quite a few commits, but it works |
ChujieChen
reviewed
May 14, 2021
ChujieChen
suggested changes
May 14, 2021
There was a problem hiding this comment.
Hey @AdvaitDhingra . Thank you for your code! This YMAL didn't work. Those four npm run lines never got a chance to run (please check the 'Details' page of this workflow). Please revise this file. Also please follow the CONTRIBUTING.md for future PRs.
.github/workflows/node.js.yml
Outdated
| - name: Test Server Side | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 12.18.3 |
|
Thanks for the review. I'll fix theses errors. |
This reverts commit 1eaaf92.
|
Hi @AdvaitDhingra , the workflow never gets run. And thus, I'm closing this PR. Please follow the CONTRIBUTING.md for future PRs (try squashing your commits with rebase -i to avoid a long list of commits). Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have set up and tested the node.js workflow. I have modified it to work with NuCat. It tests both the client and the server side.
Shold fix this issue.