Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the capability is shared before making requests #6420

Closed
pinges opened this issue Jan 17, 2024 · 2 comments
Closed

Check if the capability is shared before making requests #6420

pinges opened this issue Jan 17, 2024 · 2 comments
Labels
peering TeamRevenant GH issues worked on by Revenant Team

Comments

@pinges
Copy link
Contributor

pinges commented Jan 17, 2024

Description

Currently we do not check whether an EthPeer supports the request that we are sending, e.g. when we are sending a GetStorageRangeFromPeerTask to a peer we should check whether that peer has the capability to do SNAP.
We need to think about at what point this should be checked. It should be done when we are selecting the peers for the retrying tasks, but we might need to do that as well for the simple tasks (e.g. GetStorageRangeFromPeerTask).
@pinges pinges added the TeamRevenant GH issues worked on by Revenant Team label Jan 17, 2024
@macfarla
Copy link
Contributor

current PR #6609

@macfarla
Copy link
Contributor

closing as duplicate of #6349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
peering TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macfarla @pinges