Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: eth_call gas limit (rpc.gascap) #6042

Closed
quickchase opened this issue Oct 17, 2023 · 2 comments · Fixed by #6156
Closed

Feature Request: eth_call gas limit (rpc.gascap) #6042

quickchase opened this issue Oct 17, 2023 · 2 comments · Fixed by #6156
Assignees
@gfukushima
Labels
enhancement New feature or request mainnet RPC snack Smaller coding task - less than a day for an experienced dev TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team

Comments

@quickchase
Copy link

Description

As an RPC provider, I want a way to limit the maximum amount of gas that an eth_call can consume.

Besu is the only Ethereum client that does not have a configurable RPC gas limit/cap.

Acceptance Criteria

  • Implement a flag similar to Geth, Nethermind, Reth, Erigon, etc. rpc.gascap with a configurable gas limit.

Expected behavior: [What you expect to happen]
If someone sends an eth_call that consumes a bajillion gas, it should be killed with out of gas or other similar error.

Actual behavior: [What actually happens]
I'm not sure what the current behavior is.
@non-fungible-nelson non-fungible-nelson added mainnet RPC enhancement New feature or request snack Smaller coding task - less than a day for an experienced dev TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team TeamChupa GH issues worked on by Chupacabara Team labels Oct 23, 2023
@non-fungible-nelson
Copy link
Contributor

Thank for this - we will prioritize this soon.

Need to check the same in other methods...

@non-fungible-nelson
Copy link
Contributor

eth_estimateGas

This was referenced Nov 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfukushima gfukushima

Labels
enhancement New feature or request mainnet RPC snack Smaller coding task - less than a day for an experienced dev TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
3 participants
@gfukushima @non-fungible-nelson @quickchase