Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BadBlockManager from ProtocolSpec #5153

Closed
siladu opened this issue Mar 3, 2023 · 1 comment
Closed

Remove BadBlockManager from ProtocolSpec #5153

siladu opened this issue Mar 3, 2023 · 1 comment
Labels
TeamGroot GH issues worked on by Groot Team

Comments

@siladu
Copy link
Contributor

siladu commented Mar 3, 2023

This is a bug because when you transition to a new fork schedule, you lose your existing bad block cache.

Could do with knowing why it was added there in the first place before we blindly remove it though.

@siladu siladu added the TeamGroot GH issues worked on by Groot Team label Mar 3, 2023
@usmansaleem usmansaleem added the bug Something isn't working label Mar 5, 2023
@siladu siladu mentioned this issue Mar 13, 2023
27 tasks
@non-fungible-nelson non-fungible-nelson removed the bug Something isn't working label May 15, 2023
@siladu
Copy link
Contributor Author

siladu commented May 16, 2023

Probably not a bug so much as a feature with unintended consequences.

It make sense to partition bad blocks by fork since they blocks may be valid/invalid depending on different fork rules.

It does mean that the previous fork's bad blocks are unavailable in the debug_getBadBlocks endpoint, however that's a very minor edge case, probably not worth the effort so closing this.

If we implemented the "archive" cache mentioned in #5460 and made it agnostic of fork/protocol schedule then that may fix this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

No branches or pull requests

3 participants