Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for block height when not doing PoS #5061

Closed
pinges opened this issue Feb 7, 2023 · 0 comments
Closed

Add check for block height when not doing PoS #5061

pinges opened this issue Feb 7, 2023 · 0 comments
Assignees
Labels
mainnet peering TeamRevenant GH issues worked on by Revenant Team

Comments

@pinges
Copy link
Contributor

pinges commented Feb 7, 2023

Description

PR #3911 removed the check, because in a PoS environment the height of a peer is not updated any more. The removal of the check can lead to request that can not be satisfied by the peer, because they have not reached the necessary block height to deliver the requested header/block, which results in an empty response from that peer. This can lead to disconnection from that peer, when 5 useless responses are recorded in within 1 minute (see class PeerReputation).

The checks for the block height should be reinstated for PoW and PoA networks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mainnet peering TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

No branches or pull requests

2 participants