Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawals to handle filling empty blocks when syncing #4976

Closed
jframe opened this issue Jan 23, 2023 · 1 comment · Fixed by #5174
Closed

Withdrawals to handle filling empty blocks when syncing #4976

jframe opened this issue Jan 23, 2023 · 1 comment · Fixed by #5174
Assignees
Labels
mainnet TeamGroot GH issues worked on by Groot Team

Comments

@jframe
Copy link
Contributor

jframe commented Jan 23, 2023

The empty block check is missing checking the withdrawals in the CompleteBlocksTask hasEmptyBody method. Not sure if this is necessary, we need to understand more about what this class is doing but we need to consider withdrawals here as well.

@jframe jframe added the TeamGroot GH issues worked on by Groot Team label Jan 23, 2023
@gfukushima gfukushima assigned gfukushima and unassigned gfukushima Jan 24, 2023
@jframe jframe added the mainnet label Jan 25, 2023
@jframe
Copy link
Contributor Author

jframe commented Jan 25, 2023

CompleteBlocksTask is used only for full sync and fast which are only used before the merge. Withdrawals must be enabled after the merge and after the merge, we use backward sync which doesn't use this task. So this isn't necessary for Withdrawals as will never be used when Withdrawals is active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mainnet TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants