Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawals: Standardizing wei --> gwei between the EL and CL #4920

Closed
non-fungible-nelson opened this issue Jan 13, 2023 · 0 comments
Closed
Assignees
Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team

Comments

@non-fungible-nelson
Copy link
Contributor

https://notes.ethereum.org/@ralexstokes/withdrawals-in-gwei

Need to update the Engine Spec and work on EIP-4895 to use Gwei (which the CL uses) vs Wei that we use now. See the above spec changes.

Spec changes of note:

Engine API - the amount value is represented on the beacon chain as a little-endian value in units of Gwei, whereas the
amount in this structure MUST be converted to a big-endian value in units of Gwei.

Withdrawals POC - "4. a nonzero amount of ether given in Gwei (1e9 wei) as a uint64 value.
Recall that the amount is given in units of Gwei so a conversion to units of wei must be performed when working with account balances in the execution state."

@non-fungible-nelson non-fungible-nelson added TeamRevenant GH issues worked on by Revenant Team mainnet labels Jan 13, 2023
@jframe jframe added the TeamGroot GH issues worked on by Groot Team label Jan 15, 2023
@usmansaleem usmansaleem self-assigned this Jan 16, 2023
@non-fungible-nelson non-fungible-nelson added the EIP Ethereum Improvement Proposal label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

No branches or pull requests

4 participants