Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download folder collision #13

Open
lukechilds opened this issue Aug 26, 2016 · 0 comments
Open

Download folder collision #13

lukechilds opened this issue Aug 26, 2016 · 0 comments

Comments

@lukechilds
Copy link

If I download https://google.com/file.txt it looks like the directory for saving the progress is ~/.hget/file.txt. Is that correct?

If so, what if I pause and then start downloading https://github.com/file.txt, wouldn't they both be saved in ~/.hget/file.txt.

It looks like you're just using the basename to specify a download job

hget/util.go

Line 68 in 03213a9

func TaskFromUrl(url string) string {

I think the download task/folder should be the full url encoded in a way that's safe as a folder name, either a hash of the url or just encode some of the url params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant