Skip to content

Commit cc882b8

Browse files
author
Ferenc Nánási
committed
File info view improved, fixed missing Ionic imports on some views
1 parent 6f15781 commit cc882b8

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

src/components/audioSettingsModal.vue

+2
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ import {
5656
IonSelectOption,
5757
IonLabel,
5858
IonButtons,
59+
IonIcon,
5960
} from "@ionic/vue";
6061
import { apiInstance } from "../api";
6162
import { arrowBack } from "ionicons/icons";
@@ -135,6 +136,7 @@ export default {
135136
IonSelectOption,
136137
IonLabel,
137138
IonButtons,
139+
IonIcon,
138140
},
139141
};
140142
</script>

src/components/infoModal.vue

+20-23
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,21 @@
3636
</ion-label>
3737
</ion-item>
3838
</ion-list>
39-
40-
<ion-list-header> Metadata </ion-list-header>
41-
<ion-list>
42-
<ion-item
43-
v-for="(value, key, i) in playerData.metadata"
44-
:key="i"
45-
lines="full"
46-
>
47-
<ion-label class="ion-text-wrap">
48-
<h2>{{ key }}</h2>
49-
<p>{{ value }}</p>
50-
</ion-label>
51-
</ion-item>
52-
</ion-list>
39+
<template v-if="Object.keys(playerData.metadata).length > 0">
40+
<ion-list-header> Metadata </ion-list-header>
41+
<ion-list>
42+
<ion-item
43+
v-for="(value, key, i) in playerData.metadata"
44+
:key="i"
45+
lines="full"
46+
>
47+
<ion-label class="ion-text-wrap">
48+
<h2>{{ key }}</h2>
49+
<p>{{ value }}</p>
50+
</ion-label>
51+
</ion-item>
52+
</ion-list>
53+
</template>
5354
<template v-for="track in videoTracks" :key="track.id">
5455
<ion-list-header
5556
>Video {{ track.id }}
@@ -108,19 +109,19 @@
108109
{{ track.selected ? "(Selected)" : "" }}</ion-list-header
109110
>
110111
<ion-list>
111-
<ion-item>
112+
<ion-item lines="full">
112113
<ion-label class="ion-text-wrap">
113114
<h2>Codec</h2>
114115
<p>{{ track.codec }}</p>
115116
</ion-label>
116117
</ion-item>
117-
<ion-item>
118+
<ion-item lines="full">
118119
<ion-label class="ion-text-wrap">
119120
<h2>Language</h2>
120121
<p>{{ track.lang }}</p>
121122
</ion-label>
122123
</ion-item>
123-
<ion-item v-if="track.external_filename">
124+
<ion-item v-if="track.external_filename" lines="full">
124125
<ion-label class="ion-text-wrap">
125126
<h2>Filename</h2>
126127
<p>{{ track.external_filename }}</p>
@@ -151,6 +152,7 @@ import {
151152
IonLabel,
152153
IonItem,
153154
IonList,
155+
IonIcon,
154156
} from "@ionic/vue";
155157
import { arrowBack } from "ionicons/icons";
156158
export default {
@@ -193,12 +195,7 @@ export default {
193195
IonItem,
194196
IonList,
195197
IonButtons,
198+
IonIcon,
196199
},
197200
};
198201
</script>
199-
200-
<style scoped>
201-
.prop {
202-
overflow: scroll;
203-
}
204-
</style>

src/components/openURLModal.vue

+2
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ import {
7676
IonButtons,
7777
IonSelect,
7878
IonSelectOption,
79+
IonIcon,
7980
} from "@ionic/vue";
8081
import { arrowBack } from "ionicons/icons";
8182
import { loadFileFlags } from "../tools";
@@ -130,6 +131,7 @@ export default {
130131
IonButtons,
131132
IonSelect,
132133
IonSelectOption,
134+
IonIcon,
133135
},
134136
};
135137
</script>

src/components/subtitleSettingsModal.vue

+3-4
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ import {
9292
IonSelectOption,
9393
IonLabel,
9494
IonCheckbox,
95+
IonIcon,
9596
modalController,
9697
} from "@ionic/vue";
9798
import filebrowsermodal from "./fileBrowserModal.vue";
@@ -125,7 +126,6 @@ export default {
125126
selectedTrack.value = activeSubTrackId.value;
126127
}
127128
};
128-
console.log(playerData.value["sub-ass-override"]);
129129
const onAppendClicked = () => {
130130
props.modalController.dismiss();
131131
};
@@ -214,9 +214,7 @@ export default {
214214
}
215215
};
216216
const onAssOverridechanged = (event) => {
217-
apiInstance
218-
.post(`/tracks/sub/ass-override/${event.target.value}`)
219-
.then(() => console.log("changed"));
217+
apiInstance.post(`/tracks/sub/ass-override/${event.target.value}`);
220218
};
221219
222220
loadTracks();
@@ -253,6 +251,7 @@ export default {
253251
IonSelectOption,
254252
IonLabel,
255253
IonCheckbox,
254+
IonIcon,
256255
},
257256
};
258257
</script>

0 commit comments

Comments
 (0)