Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph Split for Pagination #49

Open
ChuanfengZhang opened this issue Jan 10, 2025 · 6 comments
Open

Paragraph Split for Pagination #49

ChuanfengZhang opened this issue Jan 10, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ChuanfengZhang
Copy link

I noticed that currently, pagination is done by nodes. If the height of a node exceeds the remaining blank space on the current page, a large blank space will be left on the current page, and the node will be moved to the next page. Do we have any plans to split nodes to address this issue?
image

@hugs7
Copy link
Owner

hugs7 commented Jan 10, 2025

Hmm, yeah you mean if you have a really long paragraph? B/c we don't want to split nodes if it's a short paragraph but I see your point for longer ones.

What do you think should be the threshold?

@hugs7
Copy link
Owner

hugs7 commented Jan 10, 2025

We also need think about how we could go about rejoining the nodes if the content changes or moves such that it would actually fit on a single page. Maybe some kind of custom attribute to the paragraph node?

@hugs7 hugs7 added the enhancement New feature or request label Jan 10, 2025
@ChuanfengZhang
Copy link
Author

I believe this isn't something simple.😵‍💫

@hugs7
Copy link
Owner

hugs7 commented Jan 10, 2025

Yeah but it's doable. Want to work on it together?

@ChuanfengZhang
Copy link
Author

I'll do my best.

@hugs7 hugs7 self-assigned this Jan 12, 2025
@hugs7
Copy link
Owner

hugs7 commented Jan 25, 2025

Sorry haven't been active this week. I'll try to take more of a look next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants