Feat: table splitting #52

azriel46d · 2025-01-22T15:46:48Z

This PR addresses basic table splitting. see #43

Future improvements

split rows where cells which are larger than a whole page.

Note the table attributes need to be extended to support groupId

export default Table.extend({
  content: 'tableRow*',

  addOptions() {
    return {
      ...this.parent?.(),
      View: CustomTableView as any,
    }
  },

  addAttributes() {
    return {
      ...this.parent?.(),
      id: {
        default: null,
      },
      groupId: {
        default: null,
      },
    }
  }

Video is as part of umo-editor

table-splitting.mov

hugs7

Thank you for putting the time into this. I'll be honest - I haven't actually tested your code to see if it works yet.

I'd like you to fix up where I've added comments, then I'd be happy to give it a test.
Let me know if you have any questions.

hugs7 · 2025-01-26T01:35:22Z

src/Plugins/Pagination.ts

@@ -73,4 +73,4 @@ const PaginationPlugin = new Plugin({
    },
 });

-export default PaginationPlugin;
+export default PaginationPlugin;


There should be a trailing blank line here.
Get prettier if you are using vscode

src/utils/pagination.ts

hugs7 · 2025-01-26T01:37:48Z

src/utils/pagination.ts

@@ -819,4 +934,4 @@ export const paginationUpdateCursorPosition = (tr: Transaction, newCursorPos: Nu
    } else {
        setSelectionAtEndOfDocument(tr);
    }
-};
+};


Blank line here required

src/utils/table.ts

azriel46d · 2025-01-27T08:58:57Z

Thanks for this thorough review.
Totally understand on comments. At the end of the day it is your repository so it needs to fit with what you deem fit .

Can you kindly share your .prettierc config. As i had to disable prettier due to a different configuration which was reformatting the whole file.

hugs7 · 2025-01-27T09:02:42Z

Sure gimme a moment to make one.

hugs7 · 2025-01-27T09:15:00Z

Okay I've pushed a .prettierrc config file. I think you should be able to rebase a fork. Here's a link from a quick Google search
https://medium.com/@topspinj/how-to-git-rebase-into-a-forked-repo-c9f05e821c8a

…d/tiptap-extension-pagination into feature/table-splitting

azriel46d · 2025-01-27T11:44:43Z

All raised issues should be resolved.

hugs7 · 2025-01-28T10:41:14Z

Great. I'll try to test it now
I will admit I haven't played much with tables in Tiptap so it might take me a bit to get a test environment working

azriel46d · 2025-01-28T11:14:33Z

No worries. Quite understandable and same for me . I ended up plugging into umo to test ...only in v5 they've removed pagination. Anyway, feel free to use or not as you wish :)

…

On Tue, 28 Jan 2025, 11:41 Hugo Burton, ***@***.***> wrote: Great. I'll try to test it now I will admit I haven't played much with tables in Tiptap so it might take me a bit to get a test environment working — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR3CPRBZQGDSJ3ZUQUDWM32M5NGBAVCNFSM6AAAAABVVIF7N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJYGYZDKMBTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

hugs7 · 2025-01-28T12:25:35Z

Out of time for me tonight. I'll try again tomorrow.

Oh I'll definitely add your work in - it's clear you've put a bit of time into it

zhuyihe · 2025-02-06T09:57:53Z

@azriel46d Thank you for your efforts! I know the author of umo. In addition, the paging function was made by another person. Now the paging person has no time to support the umo editor, which leads to more bugs in actual application. Therefore, the paging function was deleted in the v5 version and moved to the break-v4 branch. In addition, I have a little question, can your current table paging extension be able to cut cells? After all, once the cells are too large, they will leave a lot of blank space.

azriel46d · 2025-02-07T07:17:25Z

Right now it does not support cell splitting. It's an attempt to start and table splitting at row. That would be the natural next step to split and rejoin a row . It should follow probably the same approach in which on splitting a row there is a shared ID to regroup if needs be.

…

On Thu, 6 Feb 2025, 10:58 Yihe Zhu, ***@***.***> wrote: @azriel46d <https://github.com/azriel46d> Thank you for your efforts! I know the author of umo. In addition, the paging function was made by another person. Now the paging person has no time to support the umo editor, which leads to more bugs in actual application. Therefore, the paging function was deleted in the v5 version and moved to the break-v4 branch. In addition, I have a little question, can your current table paging extension be able to cut cells? After all, once the cells are too large, they will leave a lot of blank space. — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR3CPTXLCHEMEVHBAAFQVL2OMW3RAVCNFSM6AAAAABVVIF7N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZZGM2DONJSGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

azriel46d added 7 commits January 22, 2025 16:27

basic table splitting

89668d7

revert formatting

44fb62c

revert formatting

468e79d

revert formatting

4ef3317

subtract 1 for subsequent content

2af935a

fix for short tables

3c93a8c

rm redundant console.log

4dba4e4

hugs7 self-assigned this Jan 26, 2025

hugs7 self-requested a review January 26, 2025 01:33

hugs7 added the enhancement New feature or request label Jan 26, 2025

hugs7 linked an issue Jan 26, 2025 that may be closed by this pull request

Hope it can support table pagination #43

Open

hugs7 requested changes Jan 26, 2025

View reviewed changes

azriel46d added 8 commits January 27, 2025 10:22

basic table splitting

9e9e6b1

revert formatting

582102f

revert formatting

18275e7

revert formatting

befe42a

subtract 1 for subsequent content

29d84cf

fix for short tables

1b7e1ca

rm redundant console.log

de5b60b

fixes to formatting, and jsdoc

ce22674

azriel46d force-pushed the feature/table-splitting branch from 4dba4e4 to ce22674 Compare January 27, 2025 09:24

azriel46d added 6 commits January 27, 2025 10:25

reindent with prettier

ec4a038

fix typing

3cf176c

fix blank spaces prior to loops and ifs

4cbf55b

fix typings, move to smaller functions repeated tasks

aa82d20

fix typings

0e54bf3

reduce complexity

6d5e4ef

azriel46d added 4 commits January 27, 2025 11:42

Merge branch 'feature/table-splitting' of https://github.com/azriel46…

ee60b40

…d/tiptap-extension-pagination into feature/table-splitting

extraxt split logic to seprate fn

6e78c4c

split optimiseTable function

99f55df

simplify table logic in buildNewDocument

f81266b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: table splitting #52

Feat: table splitting #52

azriel46d commented Jan 22, 2025 •

edited

Loading

hugs7 left a comment

hugs7 Jan 26, 2025

hugs7 Jan 26, 2025

azriel46d commented Jan 27, 2025

hugs7 commented Jan 27, 2025

hugs7 commented Jan 27, 2025

azriel46d commented Jan 27, 2025 •

edited

Loading

hugs7 commented Jan 28, 2025

azriel46d commented Jan 28, 2025 via email

hugs7 commented Jan 28, 2025

zhuyihe commented Feb 6, 2025

azriel46d commented Feb 7, 2025 via email

Feat: table splitting #52

Are you sure you want to change the base?

Feat: table splitting #52

Conversation

azriel46d commented Jan 22, 2025 • edited Loading

hugs7 left a comment

Choose a reason for hiding this comment

hugs7 Jan 26, 2025

Choose a reason for hiding this comment

hugs7 Jan 26, 2025

Choose a reason for hiding this comment

azriel46d commented Jan 27, 2025

hugs7 commented Jan 27, 2025

hugs7 commented Jan 27, 2025

azriel46d commented Jan 27, 2025 • edited Loading

hugs7 commented Jan 28, 2025

azriel46d commented Jan 28, 2025 via email

hugs7 commented Jan 28, 2025

zhuyihe commented Feb 6, 2025

azriel46d commented Feb 7, 2025 via email

azriel46d commented Jan 22, 2025 •

edited

Loading

azriel46d commented Jan 27, 2025 •

edited

Loading