Specify min versions #2303
Merged
Specify min versions #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
5 tasks
This reverts commit be02a7f.
lewtun
approved these changes
Oct 31, 2024
| python -m pip install --upgrade pip | ||
| python -m pip install accelerate==0.34.0 | ||
| python -m pip install datasets==2.21.0 | ||
| python -m pip install transformers==4.46.0 |
There was a problem hiding this comment.
For my understanding, if we bump the min version in setup.py we also need to bump it here as well right?
There was a problem hiding this comment.
That's right.
Ideally, we would be able to pip install minimal versions via, eg, pip install --prefer_min ., but it's not possible yet, see pypa/pip#8085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a min version for
datasetsandaccelerate. It adds a test to ensure that these min version are indeed supported.I've found the specified min version by dichotomy.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.