[WhisperModel] fix bug in reshaping labels #21653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the Whisper model's forward pass, the target
labels
are reshaped using theview
method before being passed into the loss function:transformers/src/transformers/models/whisper/modeling_whisper.py
Line 1214 in 1567bef
The view method requires the Torch Tensor to be contiguous, and certain operations are commonly performed on the labels that might cause them not to be contiguous.
So using the
view
can cause problems during model training. This issue has already been fixed on another model by the @sanchit-gandhi in a PR, and I'm just replicating the same solution (usingreshape()
instead ofview()
) here for the Whisper model.