Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up setup.py #17045

Merged
merged 3 commits into from
May 2, 2022
Merged

Clean up setup.py #17045

merged 3 commits into from
May 2, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 2, 2022

What does this PR do?

This PR cleans up a bit the README in two ways:

  • Remove support for Python 3.6 as we said the current release was the last one with Python 3.6
  • Clean up a bit the authors field, description and keywords to emphasize the multimodal support.

Since the Hugging Face team is growing, I propose to replace the authors field by something more generic than adding names, let me know if you have a better idea

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@sgugger sgugger merged commit 1073f00 into main May 2, 2022
@sgugger sgugger deleted the clean_setup branch May 2, 2022 16:58
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
* Clean up setup.py

* Trigger CI

* Upgrade Python used
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* Clean up setup.py

* Trigger CI

* Upgrade Python used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants