Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add torch.no_grad when in eval mode #17020

Merged
merged 2 commits into from
May 2, 2022
Merged

add torch.no_grad when in eval mode #17020

merged 2 commits into from
May 2, 2022

Conversation

JunnYu
Copy link
Contributor

@JunnYu JunnYu commented Apr 30, 2022

What does this PR do?

Fixes (#17019)

add torch.no_grad in some run_xxx_no_trainer.py file when in eval mode

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 30, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit bdd690a into huggingface:main May 2, 2022
@JunnYu JunnYu deleted the fix-missing-torch-no-grad branch May 2, 2022 13:20
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
@JunnYu @stevhliu
add torch.no_grad when in eval mode (huggingface#17020)
eb11d6e 
* add torch.no_grad when in eval mode

* make style quality
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@JunnYu @elusenji
add torch.no_grad when in eval mode (huggingface#17020)
036b491 
* add torch.no_grad when in eval mode

* make style quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunnYu @HuggingFaceDocBuilderDev @sgugger