-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing RetriBERT tokenizer tests #17017
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the addition and the explanations regarding your choices! I agree with those 😃
I've just left 2 suggestions of change in comment
Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com>
Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com>
Hi @SaulLu, can you give me some guidance on how to proceed? The CI is throwing the following error: However, I think the naming is correct ( |
The CI error seems to me to come from the fact that 3 days ago there was a re-organisation of the test folder (#17034). To solves this, I suggest to1) merge the latest changes to main in your branch and 2) move the tests you added to conform to the new organisation ( Keep me updated! 😄 |
Hi @SaulLu, thank you very much for the reply. I think I've got it now! Can you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look perfect to me! Thanks for the contribution @mpoemsl 🚀
My pleasure! I would like to keep contributing and I was wondering if you could help me with a question related to that @SaulLu. I noticed that the |
* Create RetriBERT tests folder * Add missing RetriBERT tokenizer test file * Apply style corrections * Add non-english filter * Update tests/retribert/test_tokenization_retribert.py Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com> * Update tests/retribert/test_tokenization_retribert.py Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com> * Move test files to new directory * Update import path for testing utils to new test file structure Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com>
* Create RetriBERT tests folder * Add missing RetriBERT tokenizer test file * Apply style corrections * Add non-english filter * Update tests/retribert/test_tokenization_retribert.py Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com> * Update tests/retribert/test_tokenization_retribert.py Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com> * Move test files to new directory * Update import path for testing utils to new test file structure Co-authored-by: SaulLu <55560583+SaulLu@users.noreply.github.com>
What does this PR do?
Addresses issue #16627.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik
@SaulLu
Notes
There was no folder
tests/retribert/
yet, so I created one and put an__init__.py
in it. Is there anything else I have to do for these tests to get picked up by CI?RetriBertTokenizer
is identical toBertTokenizer
, so I mostly just duplicatedBertTokenizationTest
. Is that fine or should I rather a) write new tests from scratch or b) figure out a way to reuse the code inBertTokenizationTest
?