Update check_models_are_tested to deal with Windows path #16973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TEST_FILES_WITH_NO_COMMON_TESTS
contains forward slash likemt5/test_modeling_flax_mt5.py
.The condition
if test_file in TEST_FILES_WITH_NO_COMMON_TESTS:
incheck_models_are_tested
would give failures to fix on Windows, likeThis PR uses
test_file.replace(os.sep, "/")
to make it work on Windows too 😄