Fix HubertRobustTest
PT/TF equivalence test on GPU
#16943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
HubertRobustTest
PT/TF equivalence test on GPU.Note that
HubertRobustModelTest
hasbut
get_config()
had nodo_stable_layer_norm=self.do_stable_layer_norm
To investigate further
conv_stride=(4, 4, 4)
(the default value) has no issue on GPU, even without this PR(Does this suggest we have PT/TF Hubert behave differently with
do_stable_layer_norm=False
on GPU whenconv_stride=(3, 3, 3)
etc?)@patrickvonplaten You might have some idea about these points ..?