Replace deprecated logger.warn with warning

[sanchit-gandhi]

From Python docs:
There is an obsolete method warn which is functionally identical to warning. As warn is deprecated, please do not use it - use warning instead.

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[patrickvonplaten]

Note that we don't actively maintain those ;-)

[sanchit-gandhi]

Sure! Just covering all grounds!

[patrickvonplaten]

I think that's our internal logger here no - not Python's logger. So not sure about this change @LysandreJik

[sanchit-gandhi]

The logging module imported in this script is indeed our internal logging module that lives under the utils directory. We see here that the logger is instantiated by invoking the get_logger function from this module:

transformers/src/transformers/configuration_utils.py

Line 49 in 72728be

logger = logging.get_logger(__name__)

If we inspect the internal logging module in utils, we see that it first imports the Python logging module:

transformers/src/transformers/utils/logging.py

Line 17 in 72728be

import logging

The get_logger function simply returns the getLogger function from this Python logging module:

transformers/src/transformers/utils/logging.py

Lines 113 to 124 in 72728be

	def get_logger(name: Optional[str] = None) -> logging.Logger:
	"""
	Return a logger with the specified name.
	This function is not supposed to be directly accessed unless you are writing a custom transformers module.
	"""
	if name is None:
	name = _get_library_name()
	_configure_library_root_logger()
	return logging.getLogger(name)

Hence, our internal logger is implicitly derived from its parent Python logger, and is simply a wrapper for this module. Consequently, the advice regarding the use of warning in place of warn should still hold.

[patrickvonplaten]

Referring to @LysandreJik here :-)

[LysandreJik]

Yes, it's a good change!

[LysandreJik]

Perfect, thanks @sanchit-gandhi!