Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return input_ids in ImageGPT feature extractor #16872

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Return input_ids in ImageGPT feature extractor #16872

merged 1 commit into from
Apr 21, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Apr 21, 2022

What does this PR do?

This goes along with the deprecation of pixel_values to the profit of input_ids in the ImageGPT models.

@sgugger sgugger mentioned this pull request Apr 21, 2022
Merged
5 tasks
LysandreJik
LysandreJik approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sgugger!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit cb555af into main Apr 21, 2022
@sgugger sgugger deleted the input_image_gpt branch April 21, 2022 13:09
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@sgugger @elusenji
Return input_ids in ImageGPT feature extractor (huggingface#16872)
37d30c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@NielsRogge NielsRogge Awaiting requested review from NielsRogge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgugger @HuggingFaceDocBuilderDev @LysandreJik