-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onnx config for RoFormer #16861
Add onnx config for RoFormer #16861
Conversation
Hey nice PR! Did you try to convert one |
The documentation is not available anymore as the PR was closed or merged. |
…mers into roformer/add-onnx-config
:) |
It seems that there is 2x
Nice news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding RoFormer @skrsna and thank you to @chainyo for the review!
I agree with @chainyo's suggestions and would also like to see this included in the slow tests if possible. Could you add a roformer checkpoint to text_onnx_v2.py
please, e.g. maybe this works well: https://huggingface.co/junnyu/roformer_chinese_base
Then please run
RUN_SLOW=1 pytest tests/onnx/test_onnx_v2.py -s -k "roformer"
Thanks for the review @chainyo and @lewtun, I added roformer to the onnx test case
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for adding the slow test and checking that it works!
This LGTM so gently pinging @sgugger for final approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
* add roformer onnx config
* add roformer onnx config
What does this PR do?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.