Long QuestionAnsweringPipeline fix. #16778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LysandreJik This is not fully ready yet as the test does not really check that the bug is fixed. Do you have any ideas on how to check that behavior ? (Previous code was just silently not doing anything since the np.arrays are an array of Edit: It's not covered by a slow test. I am hesitant to remove the fast test because it does not cover this. |
|
The documentation is not available anymore as the PR was closed or merged. |
Narsil
changed the title
LysandreJik
approved these changes
Apr 20, 2022
|
I'll remove the fast test, don't want to leave a false sense of security here. |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Temporary commit witht the long QA fix. * Adding slow tests covering this fix. * Removing fast test as it doesn't fail anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This handles CLS index even on splitted QA context.
TODO update the tests for one that actually showcases the bug.
Fixes #16769
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.