Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pip install now updates #16761

Closed
wants to merge 1 commit into from
Closed

Conversation

gante
Copy link
Member

@gante gante commented Apr 13, 2022

What does this PR do?

Follow up from #16751: pip install in non-remote GHA workflows now updates packages, to allow us to override pre-installed versions.

@gante gante requested review from LysandreJik and ydshieh April 13, 2022 16:53
@gante
Copy link
Member Author

gante commented Apr 13, 2022

This PR actually needs further changes, the adding -U doesn't solve it (possibly because of other version requirements in the packages installed in the image).

Should I update the dependencies of click (to click>=8.0, required by black) and protobuf (to protobuf>=3.8.0, required by tensorflow)? cc @LysandreJik @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as I understand).
The CI still fails at this moment though. (you already mentioned it)

@sgugger
Copy link
Collaborator

sgugger commented Apr 13, 2022

It would be nice to find a general solution that won't have us needing to add a new dependency update in three weeks.

@gante
Copy link
Member Author

gante commented Apr 13, 2022

(closing the PR after some offline discussion -- going to attempt to change to cache fresh venvs instead)

@gante gante closed this Apr 13, 2022
@gante gante deleted the update_caches branch April 21, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants