-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: setup-dependent pip cache #16751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Pinging @LysandreJik also on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me!
The documentation is not available anymore as the PR was closed or merged. |
Cool, porting the changes to the other two files as well then 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learn this thing from you in this PR, @gante!
LGTM.
@gante: to learn more from you: how you figured out the cause for the error you mentioned: https://github.com/huggingface/transformers/runs/6007067240?check_suite_focus=true If it was me, I don't even know if I could figure this out! |
@ydshieh It definitely helps that I had this exact issue (stale CI caches) in my previous role :) To pin the error to this issue, I reran the failing CI workflow locally, from a fresh virtual env. Since it ran without issues, I had a look at the |
* Setup-dependent pip cache * Do not restore from old versions
What does this PR do?
This PR makes two changes to the way we cache our pip dependencies in the
add-model-like.yml
GH actions workflow:setup.py
;(this pattern exists in one of our CI files,
github-torch-hub.yml
, here)Together, these changes will make us start from a fresh environment whenever we change
setup.py
. Having a stale cache was causing us to have dependency problems (e.g. old, incompatible protobuf version), and potentially miss dependency issues from fresh installs.If you agree, I will also port these changes to
model-templates.yml
andupdate_metdata.yml
, which have the same pattern/issue. EDIT: ported.