Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_pt_tf_model_equivalence on PT side #16731

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 12, 2022

What does this PR do?

Same as in #16557, but on PT test side.

Now we only have 2 def test_pt_tf_model_equivalence in the common test files 💯

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 12, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh marked this pull request as ready for review April 12, 2022 16:54
@ydshieh ydshieh changed the title [WIP] Improve test_pt_tf_model_equivalence on PT side Improve test_pt_tf_model_equivalence on PT side Apr 12, 2022
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up thanks!

@ydshieh ydshieh force-pushed the improve_pt_tf_equiv_test_on_pt_side branch from 6baa93b to 55cea4a Compare April 19, 2022 18:47
@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 19, 2022

Merged (after a rebase)

@ydshieh ydshieh merged commit e6d23a4 into huggingface:main Apr 19, 2022
@ydshieh ydshieh deleted the improve_pt_tf_equiv_test_on_pt_side branch April 19, 2022 19:13
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* Update test_pt_tf_model_equivalence on PT side

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants