Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vit tf doctest with @add_code_sample_docstrings #16636

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

johko
Copy link
Contributor

@johko johko commented Apr 6, 2022

What does this PR do?

Creates doctest for TF version of ViT. It is a cleaner version of PR #16462 which had a messed up history.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh

@ydshieh ydshieh self-requested a review April 6, 2022 19:42
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 6, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @johko!

Very clean PR 💯 . One minor thing to fix, and we are ready to merge it.

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 8, 2022

LGTM, thank you @johko !

I ran it locally and the the doctests passed!

@sgugger Could you have a final look too?

@ydshieh ydshieh requested a review from sgugger April 8, 2022 08:21
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your PR!

@sgugger sgugger merged commit 9db2eeb into huggingface:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants