Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LayoutLMv2 tokenization docstrings #16187

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Mar 16, 2022

What does this PR do?

The tokenizers of LayoutLMv2 don't accept is_split_into_words keyword for __call__. Thus, I created a dedicated kwargs docstring to replace the one in src/transformers/tokenization_utils_base.py being used.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@NielsRogge @LysandreJik

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 16, 2022

The documentation is not available anymore as the PR was closed or merged.

@qqaatw
Copy link
Contributor Author

qqaatw commented Mar 16, 2022

Will open a follow-up PR for LayoutXLM after accepted and merged.

Copy link
Contributor

@SaulLu SaulLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 😄

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@LysandreJik
Copy link
Member

@NielsRogge can you give this a look when you have a minute?

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing :) can you rebase with the main branch, such that we can merge your PR?

@qqaatw qqaatw force-pushed the fix_layoutlmv2_docstrings branch from 231940c to 2077904 Compare April 19, 2022 08:53
@qqaatw
Copy link
Contributor Author

qqaatw commented Apr 19, 2022

Done.

@NielsRogge
Copy link
Contributor

Seems like you changed some files which shouldn't be changed, like index.mdx. Could you fix those, please?

@NielsRogge
Copy link
Contributor

Thanks, merging!

@NielsRogge NielsRogge merged commit 306c9ee into huggingface:main Apr 19, 2022
@qqaatw qqaatw mentioned this pull request May 2, 2022
5 tasks
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants