-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LayoutLMv2
tokenization docstrings
#16187
Fix LayoutLMv2
tokenization docstrings
#16187
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Will open a follow-up PR for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! 😄
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@NielsRogge can you give this a look when you have a minute? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing :) can you rebase with the main branch, such that we can merge your PR?
231940c
to
2077904
Compare
Done. |
Seems like you changed some files which shouldn't be changed, like |
Thanks, merging! |
* Fix docstrings * Fix up * Fix
What does this PR do?
The tokenizers of
LayoutLMv2
don't acceptis_split_into_words
keyword for__call__
. Thus, I created a dedicated kwargs docstring to replace the one insrc/transformers/tokenization_utils_base.py
being used.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@NielsRogge @LysandreJik