Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following up on Untangling logging #417

Closed
aymeric-roucher opened this issue Jan 29, 2025 · 0 comments · Fixed by #419
Closed

Following up on Untangling logging #417

aymeric-roucher opened this issue Jan 29, 2025 · 0 comments · Fixed by #419

Comments

@aymeric-roucher
Copy link
Collaborator

Following up on points raised in PR #316:

  • The replay method could be agent-assigned instead of memory assigned.
    This would allow to combine the current "logging steps to console" logic from agents.py from the "logging steps to console" logic in the replay method.
  • Putting logger (as in "show in console what's happening) logic in monitoring.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regressions, refactor logging and improve replay function huggingface/smolagents
1 participant
@aymeric-roucher