Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HuBERT integration available? #325

Closed
DuyguA opened this issue Apr 14, 2023 · 4 comments
Closed

HuBERT integration available? #325

DuyguA opened this issue Apr 14, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@DuyguA
Copy link

DuyguA commented Apr 14, 2023

When I try training HubertForCTC, I get the following error from IPUTrainer:

KeyError: 'HubertForCTC pipelined version not found in registry.'
@jimypbr
Copy link
Contributor

jimypbr commented Apr 19, 2023

Hi! We don't currently support HubertForCTC. It's not currently on our roadmap because we haven't had a request for it. We do support Wav2vec2ForCTC. https://github.com/huggingface/optimum-graphcore/blob/main/optimum/graphcore/models/wav2vec2/modeling_wav2vec2.py#L370
Wav2vec2 and Hubert are very similar models. It might therefore be quite straightforward to add it, copying what was done for wav2vec2.

@jimypbr jimypbr added the enhancement New feature or request label Apr 19, 2023
@jimypbr
Copy link
Contributor

jimypbr commented Apr 20, 2023

Turns out the code to port Hubert was identical to what we already had for wav2vec2. I added support for it in this PR: #347

@DuyguA
Copy link
Author

DuyguA commented Apr 20, 2023

Sounds great, huge thanks!

@DuyguA DuyguA closed this as completed Apr 20, 2023
@jimypbr
Copy link
Contributor

jimypbr commented Apr 24, 2023

merged onto main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimypbr @DuyguA