Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MotionAdapter.from_single_file #6248

Closed
2 tasks done
eps696 opened this issue Dec 20, 2023 · 22 comments
Closed
2 tasks done

MotionAdapter.from_single_file #6248

eps696 opened this issue Dec 20, 2023 · 22 comments
Assignees

Comments

@eps696
Copy link

eps696 commented Dec 20, 2023

Model/Pipeline/Scheduler description

Animatediff is a great technique with exploding interest and advancements; additional custom models start popping around in ckpt format, which cannot be loaded to diffusers in the meantime.
is it possible to implement from_single_file function for motion adapter, similar to how it's done now for say controlnet?

Open source status

  • The model implementation is available.
  • The model weights are available (Only relevant if addition is not a scheduler).

Provide useful links for the implementation

No response

@DN6
Copy link
Collaborator

DN6 commented Dec 20, 2023

Hi @eps696 this is definitely something we can consider. We're working on a clean up of from_single_file at the moment so it might take a bit of time. Could you point me to these new checkpoints? I can see if there's a way to convert them to diffusers format as an intermediate solution.

@eps696
Copy link
Author

eps696 commented Dec 20, 2023

thanks for a prompt response! here is few examples:
https://github.com/Lightricks/LongAnimateDiff
https://huggingface.co/guoyww/animatediff/tree/main [see v3 versions]

@DN6 DN6 self-assigned this Dec 26, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 19, 2024
@rishabhjain
Copy link

Agree that from_single_file method will be helpful. Since animatediff was added to diffusers, new versions for SD as well as SDXL has been released. But unable to use them, as from_single_file isn't supported and those new models are usually a single .ckpt files.

@DN6 DN6 removed the stale Issues that haven't received updates label Jan 24, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Feb 17, 2024
@yiyixuxu yiyixuxu added single_file and removed stale Issues that haven't received updates labels Feb 18, 2024
@vladmandic
Copy link
Contributor

@yiyixuxu @DN6
not sure why gh bot chose to close this as stale label was removed?

@eps696
Copy link
Author

eps696 commented Feb 26, 2024

+1, just yesterday tried fresh release - from_single_file not implemented yet for motion adapter

@DN6 DN6 reopened this Feb 26, 2024
@yiyixuxu
Copy link
Collaborator

ohh sorry 😱 I didn't know it does that

not sure why gh bot chose to close this as stale label was removed?

@DN6
Copy link
Collaborator

DN6 commented Feb 28, 2024

@eps696
Copy link
Author

eps696 commented Feb 28, 2024

Hi @eps696 have you tried using the AnimateDiff conversion scripts with those checkpoints?

no, missed it somehow, thanks for a hint!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 24, 2024
@DN6 DN6 removed the stale Issues that haven't received updates label Mar 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 18, 2024
@vladmandic
Copy link
Contributor

ping to remove stale status.

@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Apr 19, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label May 13, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label May 13, 2024
@yiyixuxu
Copy link
Collaborator

@DN6
I think this is not supported yet with the new from_single_file - do we plan to support it? should we ask community to help?

@DN6
Copy link
Collaborator

DN6 commented May 21, 2024

Yes we can 👍🏽 Was planning on adding the support this week, but definitely a good one for the community as well.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@vladmandic
Copy link
Contributor

ping to remove stale status.

@github-actions github-actions bot removed the stale Issues that haven't received updates label Sep 15, 2024
@yiyixuxu yiyixuxu self-assigned this Sep 17, 2024
Copy link

github-actions bot commented Oct 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Oct 9, 2024
@vladmandic
Copy link
Contributor

ping to remove stale status.

@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Oct 9, 2024
@DN6
Copy link
Collaborator

DN6 commented Oct 15, 2024

Hi @vladmandic we merged #8819 with single file support for MotionAdapter a little while back.

@DN6
Copy link
Collaborator

DN6 commented Oct 15, 2024

Closing since this has been completed.

@DN6 DN6 closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants