Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze because of blocking readAction #933

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

MariyaFilippova
Copy link
Contributor

the issue arises because IgnoreFileStatusProvider.getFileStatus calls a blocking read action, and then isDumb is checked, then indexes are accessed.
The problem is that despite isDumb being checked, the reindexing process starts during index access. Since index access under a blocking read action can cause a deadlock, this leads to the freeze. This happens because !isDumb does not necessarily mean that a reindexing process (even for a small number of recently changed files, e.g., 2 or 3) won’t start. As a result, the freeze occurs

@hsz hsz merged commit 9d39de4 into JetBrains:main Feb 7, 2025
1 check passed
@hsz
Copy link
Member

hsz commented Feb 7, 2025

Thank you so much, @MariyaFilippova!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.39%. Comparing base (801cf30) to head (6eb9606).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...hsz/idea/gitignore/vcs/IgnoreFileStatusProvider.kt 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   37.41%   37.39%   -0.02%     
==========================================
  Files         149      151       +2     
  Lines        2363     2308      -55     
  Branches      384      383       -1     
==========================================
- Hits          884      863      -21     
+ Misses       1372     1335      -37     
- Partials      107      110       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobiNN1
Copy link

RobiNN1 commented Feb 7, 2025

Looks like after this change this plugin works too well. It hides all files in project.

@georgechaduneli
Copy link

Looks like after this change this plugin works too well. It hides all files in project.

I have the same issue.

@Jungzl
Copy link

Jungzl commented Feb 8, 2025

image
So no tests before release?

@Sparking2
Copy link

Looks like after this change this plugin works too well. It hides all files in project.

Yup, was wondering if my PC was hanging because of other plugins (related to IA, my pc is incapable of it), and after trying multiple things, disabling basically all other plugins included bundled, and only this plugin, enabled, my project stays at “Loading” and nothing else loads

@thartl
Copy link

thartl commented Feb 8, 2025

Same here, .ignore 4.5.5 breaks PHPStorm. All directories are empty for me.

@MiniFullC
Copy link

I've encountered the same problem in IntelliJ IDEA 2024.3.2.2 (Ultimate Edition)

@YannySky
Copy link

YannySky commented Feb 8, 2025

same problem

@SUMARKER
Copy link

SUMARKER commented Feb 8, 2025

uninstall v4.5.5 and restart IDE ,found v4.5.3 is installed

@szj1214
Copy link

szj1214 commented Feb 8, 2025

I've encountered the same problem in IntelliJ IDEA 2024.3.2.2 (Ultimate Edition),But when I disable the v4.5.5 everything works fine.

@RadixIsatidis
Copy link

I've encountered the same problem in IntelliJ IDEA 2024.3.2.2 (Ultimate Edition),But when I disable the v4.5.5 everything works fine.

Same here.

@hsz
Copy link
Member

hsz commented Feb 8, 2025

Fixed with v4.5.6; sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.