Skip to content

Commit 7b3c10d

Browse files
sneharai4Sneha Rai
and
Sneha Rai
authored
Updated node logs with requested volume details (#279)
* Updated node logs Signed-off-by: Sneha Rai <sneha.rai@hpe.com> * Updated logger as per review comment Signed-off-by: Sneha Rai <sneha.rai@hpe.com> Co-authored-by: Sneha Rai <sneha.rai@hpe.com>
1 parent 616e6bc commit 7b3c10d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

pkg/driver/node_server.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ func (driver *Driver) removeStaleBindMounts(device *model.Device, stagingPath st
142142
// NodeUnstageVolume.
143143
// nolint: gocyclo
144144
func (driver *Driver) NodeStageVolume(ctx context.Context, request *csi.NodeStageVolumeRequest) (*csi.NodeStageVolumeResponse, error) {
145-
log.Trace(">>>>> NodeStageVolume")
146-
defer log.Trace("<<<<< NodeStageVolume")
145+
log.Tracef(">>>>> NodeStageVolume, VolumeId: %s, targetStagingPath: %s", request.VolumeId, request.StagingTargetPath)
146+
defer log.Tracef("<<<<< NodeStageVolume, VolumeId: %s, targetStagingPath: %s", request.VolumeId, request.StagingTargetPath)
147147

148148
if request.VolumeId == "" {
149149
return nil, status.Error(codes.InvalidArgument, "Invalid volume ID specified for NodeStageVolume")
@@ -585,8 +585,8 @@ func (driver *Driver) setupDevice(
585585
// If this RPC failed, or the CO does not know if it failed or not, it MAY choose to call NodeUnstageVolume again.
586586
// nolint: gocyclo
587587
func (driver *Driver) NodeUnstageVolume(ctx context.Context, request *csi.NodeUnstageVolumeRequest) (*csi.NodeUnstageVolumeResponse, error) {
588-
log.Trace(">>>>> NodeUnstageVolume")
589-
defer log.Trace("<<<<< NodeUnstageVolume")
588+
log.Tracef(">>>>> NodeUnstageVolume, VolumeId: %s, targetStagingPath: %s", request.VolumeId, request.StagingTargetPath)
589+
defer log.Tracef("<<<<< NodeUnstageVolume, VolumeId: %s, targetStagingPath: %s", request.VolumeId, request.StagingTargetPath)
590590

591591
if request.VolumeId == "" {
592592
return nil, status.Error(codes.InvalidArgument, "Invalid volume ID specified for NodeUnstageVolume")
@@ -741,7 +741,8 @@ func getEphemeralVolName(podName string, volumeHandle string) string {
741741
func (driver *Driver) NodePublishVolume(ctx context.Context, request *csi.NodePublishVolumeRequest) (*csi.NodePublishVolumeResponse, error) {
742742
log.Tracef(">>>>> NodePublishVolume, VolumeId: %s, stagingPath: %s, targetStagingPath: %s",
743743
request.VolumeId, request.TargetPath, request.StagingTargetPath)
744-
defer log.Trace("<<<<< NodePublishVolume")
744+
defer log.Tracef("<<<<< NodePublishVolume, VolumeId: %s, stagingPath: %s, targetStagingPath: %s",
745+
request.VolumeId, request.TargetPath, request.StagingTargetPath)
745746
targetPath := request.TargetPath
746747

747748
if request.VolumeId == "" {
@@ -1534,7 +1535,7 @@ func (driver *Driver) createEphemeralVolume(
15341535
// again.
15351536
func (driver *Driver) NodeUnpublishVolume(ctx context.Context, request *csi.NodeUnpublishVolumeRequest) (*csi.NodeUnpublishVolumeResponse, error) {
15361537
log.Tracef(">>>>> NodeUnpublishVolume, VolumeId: %s, TargetPath: %s", request.VolumeId, request.TargetPath)
1537-
defer log.Trace("<<<<< NodeUnpublishVolume")
1538+
defer log.Tracef("<<<<< NodeUnpublishVolume, VolumeId: %s, TargetPath: %s", request.VolumeId, request.TargetPath)
15381539

15391540
if request.VolumeId == "" {
15401541
return nil, status.Error(codes.InvalidArgument, "Invalid volume ID specified for NodeUnpublishVolume")

0 commit comments

Comments
 (0)