Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to mapper workflow based on in-person discussion #1949

Closed
11 of 12 tasks
spwoodcock opened this issue Dec 4, 2024 · 7 comments
Closed
11 of 12 tasks

Updates to mapper workflow based on in-person discussion #1949

spwoodcock opened this issue Dec 4, 2024 · 7 comments
Assignees
Labels
bug Something isn't working effort:medium Likely a day or two frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Dec 4, 2024

TODO

Mapper frontend (immediate):

  • Remove the lock icon on mapper frontend when feature 'OPENED_IN_ODK' (only have the yellow colour).

React frontend

  • Update text 'Select a task / feature for mapping' --> 'Click on a task to select a feature for mapping'.

  • - React frontend: add a button to refresh statuses on that map.

  • - If the React frontend project detail page is opened on a mobile device, automatically redirect to /mapnow/{project_id}

  • - Related to this, remove the 'Start Mapping' button, as it's no longer needed.

  • - Move 'Basemaps' button from bottom left of map onto the left pane: 'Generate Basemaps'.

  • - React frontend: add helper text when the page is loaded to 'Click on a task area', then have the text disappear when a task area is selected (not localStorage, but simply a conditional display: (if selectedTaskId) {showHelpText} else {doNotShowHelpText}

  • - Remove 'Start Mapping' in task popup, replace with 'Assign To Mapper'.

TODO marking features as invalid / bad

  • We don't colour the task status if features are marked bad (hasIssues).
  • We call the ODK API to get submission details, filter by all features where hasIssues in ODK.
  • We convert he JavaRosa geom from ODK to a FeatureCollection of features that have issues.
  • Load and style those geoms as a layer on top of everything that flashes to the user 'fix me!'
@spwoodcock spwoodcock added the bug Something isn't working label Dec 4, 2024
@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time frontend Related to frontend code effort:medium Likely a day or two labels Dec 4, 2024
@spwoodcock spwoodcock changed the title Updates to mapper workflow Updates to mapper workflow based on in-person discussion Dec 4, 2024
@manjitapandey
Copy link
Contributor

manjitapandey commented Dec 30, 2024

Move 'Basemaps' button from bottom left of map onto the left pane: 'Generate Basemaps'.

This will be addressed in #2037

React frontend: add helper text when the page is loaded to 'Click on a task area', then have the text disappear when a task area is selected (not localStorage, but simply a conditional display: (if selectedTaskId) {showHelpText} else {doNotShowHelpText}

@spwoodcock can you clarify, what do you mean by (if selectedTaskId) {showHelpText} else {doNotShowHelpText}?

@NSUWAL123 NSUWAL123 mentioned this issue Dec 30, 2024
7 tasks
@manjitapandey
Copy link
Contributor

React frontend: add a button to refresh statuses on that map.

Does this refresh status button refreshes both tasks and feature's update or only refresh the status of feature?? As a project manager, i won't know the accurate progress if only features status is updated through syncing since i have to click on each tasks to see the update. I would rather refresh the page to get updates of both features and tasks.

@spwoodcock
Copy link
Member Author

React frontend: add a button to refresh statuses on that map.

Does this refresh status button refreshes both tasks and feature's update or only refresh the status of feature?? As a project manager, i won't know the accurate progress if only features status is updated through syncing since i have to click on each tasks to see the update. I would rather refresh the page to get updates of both features and tasks.

Both tasks and features 👍

It should do the same as refreshing the page (call the same endpoints), without an actual refresh

@manjitapandey
Copy link
Contributor

Currently, only the feature status are updated while syncing status and tasks status are not updated.
Also in mobile view, sync status button is provided when the features are selected. We need to place it elsewhere to denote it updates both task level and feature level status.

@spwoodcock
Copy link
Member Author

I think there is a misunderstanding here maybe?

The task statuses live update via electric SQL.

The feature statuses do too!

The problem for features is the fmtm db is not updated when the user submits via ODK, meaning we have to do this 'sync' part manually

@manjitapandey
Copy link
Contributor

manjitapandey commented Jan 23, 2025

Reopening this issue, since if you unlock a task in mapper's page. clicking on sync status won't update the task status correctly.
cc: @NSUWAL123

@manjitapandey
Copy link
Contributor

sorry my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:medium Likely a day or two frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing
Projects
Development

No branches or pull requests

3 participants