Improve copy for control intents (#3519)

<!-- Thank you for submitting a Pull Request and helping to improve Home
Assistant. Please complete the following sections to help the processing
and review of your changes. Please do not delete anything from this
template. -->

## Summary
<!-- Provide a brief summary of the changes you have made and most
importantly what they aim to achieve -->

## Screenshots
<!-- If this is a user-facing change not in the frontend, please include
screenshots in light and dark mode. -->

## Link to pull request in Documentation repository
<!-- Pull requests that add, change or remove functionality must have a
corresponding pull request in the Companion App Documentation repository
(https://github.com/home-assistant/companion.home-assistant). Please add
the number of this pull request after the "#" -->
Documentation: home-assistant/companion.home-assistant#

## Any other notes
<!-- If there is any other information of note, like if this Pull
Request is part of a bigger change, please include it here. -->

Author: bgoncal

Sources/App/Resources/en.lproj/Localizable.strings

@@ -67,8 +67,9 @@
 "app_intents.intent.cover.title" = "Control cover";
 "app_intents.intent.light.title" = "Control light";
 "app_intents.intent.switch.title" = "Control switch";
-"app_intents.lights.light.target" = "Target state";
+"app_intents.state.target" = "Target state";
 "app_intents.lights.light.title" = "Light";
+"app_intents.switch.title" = "Switch";
 "app_intents.lights.off_state_icon.title" = "Icon for off state";
 "app_intents.lights.on_state_icon.title" = "Icon for on state";
 "app_intents.notify_when_run.description" = "Shows notification after executed";
@@ -1179,4 +1180,4 @@ Home Assistant is free and open source home automation software with a focus on
 "widgets.sensors.description" = "Display state of sensors";
 "widgets.sensors.not_configured" = "No Sensors Configured";
 "widgets.sensors.title" = "Sensors";
-"yes_label" = "Yes";
+"yes_label" = "Yes";

Sources/Extensions/Widgets/Controls/Light/LightIntent.swift

@@ -9,7 +9,7 @@ struct LightIntent: SetValueIntent {
     @Parameter(title: .init("app_intents.lights.light.title", defaultValue: "Light"))
     var light: IntentLightEntity
 
-    @Parameter(title: .init("app_intents.lights.light.target", defaultValue: "Target state"))
+    @Parameter(title: .init("app_intents.state.target", defaultValue: "Target state"))
     var value: Bool
 
     @Parameter(title: .init("app_intents.state.toggle", defaultValue: "Toggle"), default: false)

Sources/Extensions/Widgets/Controls/Switch/SwitchIntent.swift

@@ -6,10 +6,10 @@ import Shared
 struct SwitchIntent: SetValueIntent {
     static var title: LocalizedStringResource = .init("app_intents.intent.switch.title", defaultValue: "Control switch")
 
-    @Parameter(title: .init("app_intents.lights.light.title", defaultValue: "Light"))
+    @Parameter(title: .init("app_intents.light.title", defaultValue: "Switch"))
     var entity: IntentSwitchEntity
 
-    @Parameter(title: .init("app_intents.lights.light.target", defaultValue: "Target state"))
+    @Parameter(title: .init("app_intents.state.target", defaultValue: "Target state"))
     var value: Bool
 
     @Parameter(title: .init("app_intents.state.toggle", defaultValue: "Toggle"), default: false)

Sources/Shared/Resources/Swiftgen/Strings.swift

@@ -331,8 +331,6 @@ public enum L10n {
     }
     public enum Lights {
       public enum Light {
-        /// Target state
-        public static var target: String { return L10n.tr("Localizable", "app_intents.lights.light.target") }
         /// Light
         public static var title: String { return L10n.tr("Localizable", "app_intents.lights.light.title") }
       }
@@ -459,6 +457,10 @@ public enum L10n {
       /// Toggle
       public static var toggle: String { return L10n.tr("Localizable", "app_intents.state.toggle") }
     }
+    public enum Switch {
+      /// Switch
+      public static var title: String { return L10n.tr("Localizable", "app_intents.switch.title") }
+    }
     public enum WidgetAction {
       /// Which actions?
       public static var actionsParameterConfiguration: String { return L10n.tr("Localizable", "app_intents.widget_action.actions_parameter_configuration") }