Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 483bba6

Browse files
committed
fix(fusuma): use exec, not spawn
1 parent 1049d04 commit 483bba6

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

packages/client/src/components/Sidebar.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,7 @@ const formatStr = (num) => `${num}`.padStart(2, '0');
1212

1313
export const Sidebar = memo(
1414
({ isOpen, onStateChange, goTo, currentIndex, runPresentationMode, contents, totalSlides }) => (
15-
<Menu
16-
isOpen={isOpen}
17-
disableAutoFocus
18-
onStateChange={onStateChange}
19-
outerContainerId="root"
20-
pageWrapId="webslides"
21-
>
15+
<Menu isOpen={isOpen} disableAutoFocus onStateChange={onStateChange} outerContainerId="root">
2216
<div className="sidebar-social">
2317
{Array.isArray(sns) &&
2418
sns.map((s) => {

packages/fusuma/src/utils/getRemoteOriginUrl.js

+5-10
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,13 @@
33
const gitRemoteOriginUrl = require('git-remote-origin-url');
44

55
async function getRemoteOriginUrl() {
6-
try {
7-
let url = await gitRemoteOriginUrl();
6+
let url = await gitRemoteOriginUrl();
87

9-
if (url.includes('git@')) {
10-
url = `https://github.com/${url.split(':')[1]}`;
11-
}
12-
13-
return url;
14-
} catch (e) {
15-
console.error(e);
16-
return '';
8+
if (url.includes('git@')) {
9+
url = `https://github.com/${url.split(':')[1]}`;
1710
}
11+
12+
return url;
1813
}
1914

2015
module.exports = getRemoteOriginUrl;

packages/fusuma/src/utils/lazyloadModule.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const util = require('util');
4-
const spawn = util.promisify(require('child_process').spawn);
4+
const exec = util.promisify(require('child_process').exec);
55

66
async function lazyload(pack, cb) {
77
try {
@@ -10,8 +10,7 @@ async function lazyload(pack, cb) {
1010
if (cb) {
1111
cb('fallback');
1212
}
13-
14-
await spawn('npm', ['install', pack, '--no-save']);
13+
await exec(`npm install ${pack} --no-save`);
1514

1615
return require(pack);
1716
}

0 commit comments

Comments
 (0)