Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a high severity vulnerability introduced in highcharts-export-server #295

Closed
ayaka-kms opened this issue Aug 13, 2021 · 8 comments
Closed
Labels

Comments

@ayaka-kms
Copy link

ayaka-kms commented Aug 13, 2021

Hi, @cvasseng, a vulnerability https://www.npmjs.com/advisories/1464 is introduced in highcharts-export-server via:
● highcharts-export-server@2.1.0 ➔ phantomjs-prebuilt@2.1.14 ➔ request@2.79.0 ➔ hawk@3.1.3 ➔ cryptiles@2.0.5

phantomjs-prebuilt is a legacy package. It has not been maintained for about 3 years, and is not likely to be updated.
Is it possible to migrate phantomjs-prebuilt to other package to remediate this vulnerability?

I noticed several migration records for phantomjs-prebuilt in other js repos, such as

  1. in backstopjs, version 3.8.9 ➔ 3.9.0, remove phantomjs-prebuilt via commit
  2. in aegir, version 8.1.2 ➔ 9.0.0, remove phantomjs-prebuilt via commit

Are there any efforts planned that would remediate this vulnerability or migrate recompose?

Thanks
; )

@KacperMadej
Copy link

Hello,

Thank you for reporting the problem.

We are currently in the middle of implementing some big changes for the export server - changing from outdated PhantomJS to Puppeteer. A beta version for testing is expected later this year. The transition is planned for Q4 2021 - Q1 2022.

Because of this, all minor fixes are placed on hold and will be picked up after the transition - in case the transition itself won't fix the problems. If the problem that you have currently is critical for security reasons it will be fixed right away, but other problems will have to wait a bit. While waiting we will be trying to suggest a workaround solution for you.

Thank you for your patience and understanding.

The transition explained above should resolve this problem.

@ssgriffen
Copy link

@KacperMadej Any update on the above transition planned for Q4 2021 - Q1 2022?

@KacperMadej
Copy link

The transition will not be done in Q4 2021. There is no update - Q1 2022 is still the target.
Is there anything else to add here? @madepiet @PaulDalek

@joeSalvadorLauret
Copy link

@KacperMadej is Q1 2022 still the target to be achieved? (My question is because there is only a month left) Are there any updates about the transition?

Thanks in advance for the info

@KacperMadej
Copy link

@joeSalvadorLauret

is Q1 2022 still the target to be achieved?

Yes, the current internal ETA is about 3 weeks, so if everything goes well it will be published around the end of March and the beginning of April. The possibility of going into Q2 is "moderate to high", but we are actively working on the code - it will be published when safe and ready.

@joeSalvadorLauret
Copy link

@joeSalvadorLauret

is Q1 2022 still the target to be achieved?

Yes, the current internal ETA is about 3 weeks, so if everything goes well it will be published around the end of March and the beginning of April. The possibility of going into Q2 is "moderate to high", but we are actively working on the code - it will be published when safe and ready.

@KacperMadej Oh mann Just hoping you're right!! :) We're waiting for the good news!

Still wondering if it will come in time..

@carlosloureda
Copy link

Hi! Just hit this vulnerability. Didn´t see the version 3 released. Which is the state for that release? Thanks

@jszuminski
Copy link
Contributor

We're trying hard to reduce vulnerabilities in the latest Puppeteer-based version of the Export Server and this should no longer be a problem.

I encourage you to try it out, here's a short setup guide: https://github.com/highcharts/node-export-server#puppeteer-version-information

Please feel free to report any problems you encounter with the newest version and we will investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants