fix: add long types declaration locally so we dont have to rely on remote declaration #2697
+470
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
|
agadzhalov
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds
types/long.d.tsdue to the transpiler not being able to find the defaultLongtype. We already useallowSyntheticDefaultImportsproperty but if I try to import only the type oflongusingtypedef {import("long")}it will transpile the code totypedef {import("long")}.defaultinside the.d.tsfiles in the SDK. This will show an error. I try to circumvent this error by importing theLongclass declaration locally. I think it might have something to do with the way they export the Long class. Similar issues has been raised here and here.Checklist