Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb支持非root用户连接 #618

Merged
merged 1 commit into from
Feb 9, 2020
Merged

mongodb支持非root用户连接 #618

merged 1 commit into from
Feb 9, 2020

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Feb 2, 2020

  • 实例配置表新增默认数据库配置
  • engine方法get_all_tables、get_all_columns_by_tb、describe_table、query增加关键字参数,统一调用
  • 优化查询页的按钮和展示控制
  • mongodb支持非root用户连接 mongodb是否可以支持非root用户认证吗 #582

@stale stale bot added the wontfix This will not be worked on label Feb 5, 2020
Repository owner deleted a comment from stale bot Feb 6, 2020
@stale stale bot removed the wontfix This will not be worked on label Feb 6, 2020
@hhyo hhyo added the enhancement New feature or request label Feb 6, 2020
engine方法增加关键字参数,统一调用
优化查询页的按钮和展示控制
@hhyo hhyo force-pushed the feature/mongo-features branch from 8948437 to a588e57 Compare February 8, 2020 07:16
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #618 into master will increase coverage by 0.06%.
The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   81.66%   81.72%   +0.06%     
==========================================
  Files          77       77              
  Lines       10319    10317       -2     
==========================================
+ Hits         8427     8432       +5     
+ Misses       1892     1885       -7
Impacted Files Coverage Δ
sql/instance.py 52.23% <0%> (+1.51%) ⬆️
sql/engines/mysql.py 90.39% <100%> (ø) ⬆️
sql/engines/pgsql.py 79.61% <100%> (+0.63%) ⬆️
sql/engines/tests.py 99.59% <100%> (-0.01%) ⬇️
sql/engines/__init__.py 72.34% <100%> (+0.6%) ⬆️
sql/query.py 70.74% <100%> (+0.47%) ⬆️
sql/engines/mssql.py 84.71% <100%> (ø) ⬆️
sql/engines/redis.py 81.52% <100%> (ø) ⬆️
common/tests.py 100% <100%> (ø) ⬆️
sql/engines/oracle.py 95.31% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7194599...a588e57. Read the comment docs.

@hhyo hhyo marked this pull request as ready for review February 8, 2020 08:28
@hhyo hhyo requested a review from LeoQuote February 8, 2020 10:01
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeoQuote
Copy link
Collaborator

LeoQuote commented Feb 8, 2020

一改就要改一圈,太死了改起来蛋疼,太活了又没法复用,脑壳痛🙃

@LeoQuote
Copy link
Collaborator

LeoQuote commented Feb 8, 2020

要是能有个support matrix 接口,然后根据这个matrix 渲染可能会比较好,最好是自动启用的

@hhyo hhyo changed the title 处理mongo相关issue mongodb支持非root用户连接 Feb 9, 2020
@hhyo
Copy link
Owner Author

hhyo commented Feb 9, 2020

要是能有个support matrix 接口,然后根据这个matrix 渲染可能会比较好,最好是自动启用的

针对前端还是服务端的?你睡得有点晚啊~

@hhyo hhyo merged commit d832e4f into master Feb 9, 2020
@LeoQuote
Copy link
Collaborator

LeoQuote commented Feb 9, 2020

肯定是后端返回的数据,可能是在启动的时候import所有engine,然后按照import情况,以及各方法实现情况自动设置系统是否启用的值...

@hhyo hhyo deleted the feature/mongo-features branch April 20, 2020 14:55
xxlaila pushed a commit to xxlaila/Archery that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants