improved(display): Treat lines as solid when "strokeDasharray" is a dynamic StyleExpression and dashSize resolves to 0

TerminalTim · TerminalTim · commit 7e00e621874c · 2025-02-25T13:32:55.000+01:00
Signed-off-by: Tim Deubler &lt;tim.deubler@here.com&gt;
diff --git a/packages/display/src/displays/webgl/glsl/line_fragment.glsl b/packages/display/src/displays/webgl/glsl/line_fragment.glsl
@@ -26,7 +26,8 @@ void main(void){
     }
 
     #ifdef DASHARRAY
-        float dashSize = v_dashSize.x;
+        // Ensure dashSize remains valid: if set to 0 (dynamic uniform), set to large value to force a solid line
+        float dashSize = v_dashSize.x + (1.0 - step(0.1, v_dashSize.x)) * 1e5;
         float gapSize = v_dashSize.y;
         float totalDashSize = dashSize + gapSize;
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ void main(void){`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`#ifdef DASHARRAY`
`29`		`- float dashSize = v_dashSize.x;`
	`29`	`+ // Ensure dashSize remains valid: if set to 0 (dynamic uniform), set to large value to force a solid line`
	`30`	`+ float dashSize = v_dashSize.x + (1.0 - step(0.1, v_dashSize.x)) * 1e5;`
`30`	`31`	`float gapSize = v_dashSize.y;`
`31`	`32`	`float totalDashSize = dashSize + gapSize;`
`32`	`33`