-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddnet: Introduce ddnet DemoWriter
#86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit sad that this is married to gamenet_ddnet
. This means that you can only update gamenet_ddnet
in lockstep with demo
if you want to update one of them. It seems the intersections points are few: message parsing, snapshot object serialization, snapshot object lengths. Could these be replaced by not parsing messages, getting objects as integer arrays and passing in a function for that instead? I guess you did it for usability, but I'm not sure how the usability compares if you don't do it.
3201c81
to
8e0a0e4
Compare
Also add `--ddnet` option to demo_read_write tool.
8e0a0e4
to
9116184
Compare
If the dependency is a blocking concern for a future release on crates.io, then I'll fix it. I myself am only interested in DDNet right now, so tried to get that to work, so that others can skip that work. |
Probably not, no. The protocol is going to change in ways that are incompatible for this crate. |
In case of no blocking concerns, could this please get merged? |
Also add
--ddnet
option to demo_read_write tool.It automatically writes deltas and only full snapshots every 5 seconds.
Delta timings verified with a random demo.