Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code entity generator command #185

Merged
merged 12 commits into from
Aug 31, 2014
Merged

Duplicate code entity generator command #185

merged 12 commits into from
Aug 31, 2014

Conversation

omero
Copy link
Contributor

@omero omero commented Aug 31, 2014

No description provided.

omero added 10 commits August 29, 2014 01:52
@omero
Add GeneratorEntityCommand class
fdd8d32
@omero
remove duplicate code in GeneratorEntityContentCommand class and adde…
afa81af 
…d to GeneratorEntityCommand class
@omero
remove duplicate code in GeneratorEntityConfigCommand class and added…
9742518 
… to GeneratorEntityCommand class
@omero
udpate README.md with the new entity generator commands
e1ac985
@omero
Merge remote-tracking branch 'upstream/master' into duplicate_code_en…
9597afb 
…tity_generator_command
@omero
add getEntityType and getCommandName on GeneratorEntityCommand class
7328b34
@omero
add getFormType and getCommandName on GeneratorFormCommand class
0f371b6
@omero
initialize FormType and CommandName on GeneratorConfigFormBaseCommand…
b72abb4 
…class
@omero
initialize EntityType and CommandName on GeneratorEntityConfigCommand…
7856d37 
… class
@omero
initialize EntityType and CommandName on GeneratorEntityContentComman…
e031fbe 
…d class
dmouse
dmouse reviewed Aug 31, 2014
View reviewed changes
src/Command/GeneratorEntityConfigCommand.php
@@ -1,101 +1,21 @@
<?php
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set the docblock

dmouse added a commit that referenced this pull request Aug 31, 2014
@dmouse
Merge pull request #185 from omero/duplicate_code_entity_generator_co…
7c3c601 
…mmand

Duplicate code entity generator command
@dmouse dmouse merged commit 7c3c601 into hechoendrupal:master Aug 31, 2014
@dmouse
Copy link
Member

dmouse commented Aug 31, 2014

Thanks =)

@omero
Copy link
Contributor Author

omero commented Aug 31, 2014

thanks to you guys !!, its a placer to me :)

@omero omero deleted the duplicate_code_entity_generator_command branch August 31, 2014 05:29
g3r4 pushed a commit to g3r4/drupal-console that referenced this pull request Jul 19, 2017
@jmolivas
[console] Remove command aliases. (hechoendrupal#185)
ee2db73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omero @dmouse