Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-4119: Fix yarn start:test:graph not properly compiling Rust crates #6552

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

yarn start:test:graph did not wait for the compilation to be finished.

🔍 What does this change?

Let the compile task a dependency of the healthcheck tasks

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • affected the execution graph, and the turbo.json's have been updated to reflect this

@TimDiekmann TimDiekmann requested a review from CiaranMn February 26, 2025 10:17
@TimDiekmann TimDiekmann self-assigned this Feb 26, 2025
@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Feb 26, 2025
Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.7 \mathrm{ms} \pm 216 \mathrm{μs}\left({\color{gray}0.405 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$15.8 \mathrm{ms} \pm 172 \mathrm{μs}\left({\color{lightgreen}-5.286 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.9 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{lightgreen}-32.096 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.2 \mathrm{ms} \pm 161 \mathrm{μs}\left({\color{lightgreen}-11.720 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.2 \mathrm{ms} \pm 153 \mathrm{μs}\left({\color{lightgreen}-9.048 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.4 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{lightgreen}-27.879 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.0 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{lightgreen}-9.315 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.1 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{gray}-3.661 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.4 \mathrm{ms} \pm 258 \mathrm{μs}\left({\color{red}5.15 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.23 \mathrm{ms} \pm 7.50 \mathrm{μs}\left({\color{gray}-0.917 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.00 \mathrm{ms} \pm 5.67 \mathrm{μs}\left({\color{gray}-0.798 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.12 \mathrm{ms} \pm 24.9 \mathrm{μs}\left({\color{gray}1.59 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.39 \mathrm{ms} \pm 12.8 \mathrm{μs}\left({\color{gray}0.314 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.99 \mathrm{ms} \pm 8.47 \mathrm{μs}\left({\color{gray}-1.021 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.12 \mathrm{ms} \pm 5.93 \mathrm{μs}\left({\color{gray}-2.033 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10000 entities $$9.41 \mathrm{ms} \pm 79.1 \mathrm{μs}\left({\color{lightgreen}-29.973 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.14 \mathrm{ms} \pm 8.94 \mathrm{μs}\left({\color{gray}1.17 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.00 \mathrm{ms} \pm 6.30 \mathrm{μs}\left({\color{gray}-1.000 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.15 \mathrm{ms} \pm 11.6 \mathrm{μs}\left({\color{red}5.95 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.00 \mathrm{ms} \pm 6.57 \mathrm{μs}\left({\color{gray}-0.438 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.8 \mathrm{ms} \pm 367 \mathrm{μs}\left({\color{gray}2.09 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$37.7 \mathrm{ms} \pm 271 \mathrm{μs}\left({\color{gray}-0.482 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$43.5 \mathrm{ms} \pm 347 \mathrm{μs}\left({\color{gray}4.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$57.5 \mathrm{ms} \pm 303 \mathrm{μs}\left({\color{gray}3.17 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$66.2 \mathrm{ms} \pm 256 \mathrm{μs}\left({\color{gray}-1.831 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$48.9 \mathrm{ms} \pm 367 \mathrm{μs}\left({\color{gray}3.02 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$88.4 \mathrm{ms} \pm 681 \mathrm{μs}\left({\color{gray}-1.647 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.6 \mathrm{ms} \pm 180 \mathrm{μs}\left({\color{gray}0.304 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$75.6 \mathrm{ms} \pm 350 \mathrm{μs}\left({\color{gray}-1.193 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$90.1 \mathrm{ms} \pm 483 \mathrm{μs}\left({\color{gray}-1.541 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$101 \mathrm{ms} \pm 593 \mathrm{μs}\left({\color{gray}1.21 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$84.9 \mathrm{ms} \pm 590 \mathrm{μs}\left({\color{gray}-0.392 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$58.7 \mathrm{ms} \pm 261 \mathrm{μs}\left({\color{red}33.1 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$27.8 \mathrm{ms} \pm 293 \mathrm{μs}\left({\color{gray}2.67 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$5.58 \mathrm{s} \pm 282 \mathrm{ms}\left({\color{red}1973 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$86.9 \mathrm{ms} \pm 320 \mathrm{μs}\left({\color{lightgreen}-52.389 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$21.2 \mathrm{ms} \pm 88.8 \mathrm{μs}\left({\color{gray}1.47 \mathrm{\%}}\right) $$ Flame Graph

auto-merge was automatically disabled February 26, 2025 11:01

Pull Request is not mergeable

Merged via the queue into main with commit db8acd1 Feb 26, 2025
76 checks passed
@TimDiekmann TimDiekmann deleted the t/h-4119-fix-yarn-starttestgraph-not-properly-compiling-rust-crates branch February 26, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants