diff --git a/changelog/25235.txt b/changelog/25235.txt new file mode 100644 index 000000000000..d4df23ebf49b --- /dev/null +++ b/changelog/25235.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Do not disable JSON display toggle for KV version 2 secrets +``` \ No newline at end of file diff --git a/changelog/25269.txt b/changelog/25269.txt new file mode 100644 index 000000000000..706c5abe4c67 --- /dev/null +++ b/changelog/25269.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Fix copy button not working on masked input when value is not a string +``` \ No newline at end of file diff --git a/ui/lib/core/addon/components/json-editor.hbs b/ui/lib/core/addon/components/json-editor.hbs index c92b5dd3f2d2..7aac5d6f773f 100644 --- a/ui/lib/core/addon/components/json-editor.hbs +++ b/ui/lib/core/addon/components/json-editor.hbs @@ -27,6 +27,19 @@ {{/if}} + {{#if (and @allowObscure @readOnly)}} + {{! For safety we only use obscured values in readonly mode }} +
+ + Reveal values + +
+ {{/if}}
@@ -71,7 +70,7 @@ {{/if}} - {{#if (includes index this.whitespaceWarningRows)}} + {{#if (this.showWhitespaceWarning row.name)}}
{{/if}} + {{#if (this.showNonStringWarning row.value)}} +
+ +
+ {{/if}} {{/each}} {{#if this.hasDuplicateKeys}} diff --git a/ui/lib/core/addon/components/kv-object-editor.js b/ui/lib/core/addon/components/kv-object-editor.js index 40d0f3974f56..7fd7d17234ec 100644 --- a/ui/lib/core/addon/components/kv-object-editor.js +++ b/ui/lib/core/addon/components/kv-object-editor.js @@ -9,7 +9,6 @@ import { isNone } from '@ember/utils'; import { assert } from '@ember/debug'; import { action } from '@ember/object'; import { guidFor } from '@ember/object/internals'; -import { A } from '@ember/array'; import KVObject from 'vault/lib/kv-object'; /** @@ -26,7 +25,7 @@ import KVObject from 'vault/lib/kv-object'; * ``` * @param {string} value - the value is captured from the model. * @param {function} onChange - function that captures the value on change - * @param {boolean} [isMasked = false] - when true the renders instead of the default