Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultTemplateConfigMaxConnsPerHost not enforced if template_config block is missing #24988

Closed
indjb opened this issue Jan 23, 2024 · 0 comments · Fixed by #24989
Closed

DefaultTemplateConfigMaxConnsPerHost not enforced if template_config block is missing #24988

indjb opened this issue Jan 23, 2024 · 0 comments · Fixed by #24989

Comments

@indjb
Copy link
Contributor

indjb commented Jan 23, 2024

Describe the bug
#24548 adds support for setting MaxConnectionsPerHost in a Vault-agent configuration, including a default of 10. But the default is not used if the template_config block is totally missing from the configuration.

To Reproduce
Run Vault agent using a configuration that includes no template_config block. Observe that connections are not limited and pooled as they should be.

Expected behavior
The default should be enforced even when a template_config block is missing.

Environment:
This bug exists on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant